Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following a log-in link does not end & replace the previous user session #34

Closed
warrensearle opened this issue Jul 17, 2020 · 3 comments
Closed

Following a log-in link does not end & replace the previous user session #34

warrensearle opened this issue Jul 17, 2020 · 3 comments
Assignees
@crablab @warrensearle
Labels
assessments: 0.3.0 bug Something isn't working
Milestone
20JULB

Comments

@warrensearle
Copy link
Member

When logged in as user A, if we follow a log in link for user B we remain logged in as user A.
In order to continue as user B this means there's a need for the assessor to log out before they try to log in.

This will be confusing where an assessor has multiple email addresses, say, or where they are using a shared computer with another assessor.

Actual
When logged in as user A, if we follow a log in link for user B we remain logged in as user A

Expected
When logged in as user A, if we follow a log in link for user B we should be logged in as user B
@warrensearle warrensearle added the bug Something isn't working label Jul 17, 2020
@crablab
Copy link
Contributor

crablab commented Jul 17, 2020

Proposed fix to ensure we clear local storage whenever the log-in page is hit. This will force the user to re-authenticate every time they use a sign-in link

@crablab crablab mentioned this issue Jul 17, 2020
Closed
@crablab crablab self-assigned this Jul 17, 2020
@warrensearle warrensearle self-assigned this Jul 17, 2020
warrensearle added a commit that referenced this issue Jul 17, 2020
@warrensearle
#34 Fix login issues:
6ad5728 
- Should not redirect to assessments
- Ensure session updates correctly when logging in
- Fix console error when signing out
@warrensearle
Copy link
Member Author

Looks like the changes here also fix #35 and #26

warrensearle added a commit that referenced this issue Jul 17, 2020
@warrensearle
Merge pull request #38 from jac-uk/feature/34-login-issue
1473a7a 
#34 Fix login issues:
This was referenced Jul 17, 2020
Closed
Closed
@warrensearle warrensearle added this to the 20JULB milestone Jul 17, 2020
warrensearle added a commit that referenced this issue Jul 17, 2020
@warrensearle
Bump version number to 0.3.0
05768a7 
Release notes:
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends & replaces previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
@crablab
Copy link
Contributor

crablab commented Jul 20, 2020

Fixed :)

warrensearle added a commit that referenced this issue Jul 20, 2020
@warrensearle
Merge tag '0.3.0' into develop
84e96e4 
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crablab crablab

@warrensearle warrensearle

Labels
assessments: 0.3.0 bug Something isn't working
Projects
None yet
Milestone
20JULB
Development

No branches or pull requests
2 participants
@crablab @warrensearle