Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "upload" button #27

Closed
crablab opened this issue Jul 16, 2020 · 1 comment
Closed

Rename "upload" button #27

crablab opened this issue Jul 16, 2020 · 1 comment
Assignees
@crablab
Labels
assessments: 0.3.0 bug Something isn't working
Milestone
20JULB

Comments

@crablab
Copy link
Contributor

crablab commented Jul 16, 2020

When an assessor is reviewing all the IAs to complete, the list shows an "upload" button. This is misleading as if they haven't already, this is where the assessor would download the template as well as upload the file.

We should rename the button to be more accurate, for example: "View Assessment".

unnamed.png
@crablab crablab added the bug Something isn't working label Jul 16, 2020
@crablab crablab self-assigned this Jul 16, 2020
crablab added a commit that referenced this issue Jul 17, 2020
@crablab
Merge pull request #31 from jac-uk/27-rename-upload-button
d3f0447 
#27 Change for assesment buttons, and button classes
@warrensearle warrensearle added this to the 20JULB milestone Jul 17, 2020
warrensearle added a commit that referenced this issue Jul 17, 2020
@warrensearle
Bump version number to 0.3.0
05768a7 
Release notes:
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends & replaces previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
@crablab
Copy link
Contributor Author

crablab commented Jul 20, 2020

Working :)

warrensearle added a commit that referenced this issue Jul 20, 2020
@warrensearle
Merge tag '0.3.0' into develop
84e96e4 
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crablab crablab

Labels
assessments: 0.3.0 bug Something isn't working
Projects
None yet
Milestone
20JULB
Development

No branches or pull requests
2 participants
@crablab @warrensearle