Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mal-formed login links should be rejected #35

Closed
warrensearle opened this issue Jul 17, 2020 · 2 comments
Closed

Mal-formed login links should be rejected #35

warrensearle opened this issue Jul 17, 2020 · 2 comments
Assignees
@warrensearle
Labels
assessments: 0.3.0 bug Something isn't working
Milestone
20JULB

Comments

@warrensearle
Copy link
Member

Actual
When following a mal-formed login link the user is half logged in and instructed to reload the page - see screen grab below. This leaves the user somewhat in limbo.

Expected
When following a mal-formed login link the user should not be redirected to the login page.
The login page should have appropriate messaging for the user (the default instructions on the page may suffice in the first instance)
@warrensearle warrensearle added the bug Something isn't working label Jul 17, 2020
@warrensearle warrensearle self-assigned this Jul 17, 2020
@warrensearle warrensearle mentioned this issue Jul 17, 2020
Closed
@warrensearle
Copy link
Member Author

warrensearle commented Jul 17, 2020 •
edited

This appears to be fixed by the work carried out in #34

@warrensearle warrensearle added this to the 20JULB milestone Jul 17, 2020
warrensearle added a commit that referenced this issue Jul 17, 2020
@warrensearle
Bump version number to 0.3.0
05768a7 
Release notes:
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends & replaces previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
@crablab
Copy link
Contributor

crablab commented Jul 20, 2020

Fixed :)

warrensearle added a commit that referenced this issue Jul 20, 2020
@warrensearle
Merge tag '0.3.0' into develop
84e96e4 
 #19 Add sentry logging
 #26 Ensure login link takes user to assessment page
 #27 Rename "upload" button
 #34 Ensure following a log-in link ends previous session
 #35 Ensure mal-formed login links are rejected
 #39 Update favicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warrensearle warrensearle

Labels
assessments: 0.3.0 bug Something isn't working
Projects
None yet
Milestone
20JULB
Development

No branches or pull requests
2 participants
@crablab @warrensearle