Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply-lens is a bad name #40

Closed
jackfirth opened this issue Jul 6, 2015 · 3 comments
Closed

apply-lens is a bad name #40

jackfirth opened this issue Jul 6, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@jackfirth
Copy link
Owner

Lenses aren't really supposed to be interpreted as functions any more outside of applicable lenses. Non exhaustive list of possible better names:

  • lens-view/context
  • lens-view+context
  • focus-lens
  • lens-values
This was referenced Jul 6, 2015
@jackfirth jackfirth added this to the 1.0 milestone Jul 6, 2015
@jackfirth jackfirth self-assigned this Jul 7, 2015
jackfirth referenced this issue Jul 7, 2015
@AlexKnauth
Copy link
Collaborator

For consistency, since lens-view, lens-set, and lens-transform all begin with lens, should focus-lens and let-lens begin with lens too, making them lens-focus and lens-let? (you could keep let-lens as an alias for backwards-compatability) Or is there a better way to name them consistently? (lens-focus seems wrong somehow?)

@jackfirth
Copy link
Owner Author

focus-lens definitely should be lens-focus for consistency, and that sounds alright to me. Could you elaborate on the "seems wrong" part? let-lens probably shouldn't for backwards compatibility, though that should be filed away into a list of changes that we want to make if we ever make a lens2 package.

@AlexKnauth
Copy link
Collaborator

I'm not sure. Coming back to it it doesn't seem as wrong though. I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants