Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Deprecation warning when built manually with sass #15

Open
timobrembeck opened this issue Jun 7, 2021 · 0 comments
Open

Deprecation warning when built manually with sass #15

timobrembeck opened this issue Jun 7, 2021 · 0 comments

Comments

@timobrembeck
Copy link

timobrembeck commented Jun 7, 2021

I build flagpack manually with sass, and since version 1.33.0, I get a few deprecation warnings:

"Using / for division is deprecated and will be removed in Dart Sass 2.0.0"

https://sass-lang.com/documentation/breaking-changes/slash-div

DEPRECATION WARNINGS
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4, 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │     width: (4 / 3) * $size;
  │             ^^^^^
  ╵
    node_modules/flagpack/src/_mixins.scss 6:13  fp-size()
    node_modules/flagpack/src/flagpack.scss 8:5  @import
    src/frontend/css/style.scss 5:9              root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fp-size, 6)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
19 │       @include fp-rounded($fp-size / 6);
   │                           ^^^^^^^^^^^^
   ╵
    node_modules/flagpack/src/flagpack.scss 19:27  @import
    src/frontend/css/style.scss 5:9                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fp-size, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
38 │           @include fp-rounded($fp-size / 4);
   │                               ^^^^^^^^^^^^
   ╵
    node_modules/flagpack/src/flagpack.scss 38:31  @import
    src/frontend/css/style.scss 5:9                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fp-size, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
59 │           @include fp-rounded($fp-size / 4);
   │                               ^^^^^^^^^^^^
   ╵
    node_modules/flagpack/src/flagpack.scss 59:31  @import
    src/frontend/css/style.scss 5:9                root stylesheet

Since node-sass is deprecated in favor of dart-sass, I think flagpack should adapt its syntax here.

timobrembeck referenced this issue in timobrembeck/flagpack-dart-sass Jun 7, 2021
- Use `math.div()` instead of `/` for division in sass
- Require at least sass version 1.33.0

Fixes #15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant