Favicon

[wereHamster]

It would be nice if the returned metadata included links to the favicon. Do you think such a feature is in scope of this package?

[jacktuck]

We should already be returning the favicon - so maybe the code for doing so needs tweaking.

unfurl/src/index.ts

Line 195 in 76cab79

if (this._favicon === undefined) {

Do you have an example where the favicon is not being picked up?

[wereHamster]

I was not looking at the source code, I was looking at the Metadata type that is described in the readme, which does not mention the favicon. The favicon is indeed being extracted correctly in the few tests I did.

Maybe the readme can link directly to the TypeScript Metadata type in the source code instead of repeating it?

[github-actions]

🎉 This issue has been resolved in version 5.2.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀