Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support limit configuration as percent #534
Support limits configured as decimal or percent.
I am in the process of migrating a large number of projects over to jacoco from clover due to the recent byte code filtering enhancements. In an attempt to minimize the amount of changes. I would like to be able to represent the coverage target in the same data format. My proposal is to support decimal and percent configurations by parsing the value in setMinimum and setMaximum. I'm not sure on the process this project follows for contributions since I didn't find anything in the readme/wiki. Is this a change you would be willing to accept? If so, I will issue a pull request.
<limit> <counter>INSTRUCTION</counter> <minimum>0.105</minimum> <minimum>10.5%</minimum> </limit>
@mattnelson In general we accept PRs here. We're a pit picky about quality and clear concepts though
But you proposal sounds reasonable. Please find some information for contributions here: