Skip to content

Support limit configuration as percent #534

@mattnelson

Description

@mattnelson

Support limits configured as decimal or percent.

I am in the process of migrating a large number of projects over to jacoco from clover due to the recent byte code filtering enhancements. In an attempt to minimize the amount of changes. I would like to be able to represent the coverage target in the same data format. My proposal is to support decimal and percent configurations by parsing the value in setMinimum[1] and setMaximum[2]. I'm not sure on the process this project follows for contributions since I didn't find anything in the readme/wiki. Is this a change you would be willing to accept? If so, I will issue a pull request.

<limit>
    <counter>INSTRUCTION</counter>
    <minimum>0.105</minimum>
    <minimum>10.5%</minimum>
</limit>

[1] https://github.com/jacoco/jacoco/blob/v0.7.9/org.jacoco.report/src/org/jacoco/report/check/Limit.java#L126
[2] https://github.com/jacoco/jacoco/blob/v0.7.9/org.jacoco.report/src/org/jacoco/report/check/Limit.java#L147

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions