-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support limit ratios as percents #536
Conversation
Not sure what caused the build failure it might be transient. travis
local
|
@mattnelson yes - this test is unstable, relaunched |
this.minimum = minimum == null ? null : new BigDecimal(minimum); | ||
if (minimum == null) { | ||
this.minimum = null; | ||
} else if (isPercent(minimum)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the parsing logic in setMinimum() and setMaximum() can go in a common method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in c39e3d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattnelson Looks good to me now, thanks!
@mattnelson I added documentation for Ant task and updated change log. Can you please check? |
+1 to 129201d |
Should the version in master be updated to 0.8.0? https://github.com/jacoco/jacoco/blob/master/pom.xml#L6 |
@mattnelson IMO there is no need to change version of snapshot even if next release most likely will be 0.8.0 instead of 0.7.9. |
Pull request for #534