Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust/remove obsolete links #2

Merged
merged 1 commit into from
Jun 11, 2016
Merged

Adjust/remove obsolete links #2

merged 1 commit into from
Jun 11, 2016

Conversation

Godin
Copy link
Member

@Godin Godin commented Jun 10, 2016

I've got an email :

Hello Evgeny,

I'm not certain you're the best person to contact, but yours is the first email address I can find, so hopefully you can pass it on as appropriate.

I installed EclEmma recently to do code coverage analysis of our test suite. In the resources section of the EclEmma website, the following at least are dead links:

Tony Obermeit: "Code Coverage Lessons" - Read why Tony recommends 100% code coverage for your test suites.
Andrew Glover: "Don't be fooled by the coverage report" - This article shows some risks when misusing coverage reports in projects.

Best wishes,

Frederic Heath-Renn
Twickets, Ltd.

Response was - to use mailing list in future for such notifications.
But anyway we should do a check followed by a fix.

@Godin Godin self-assigned this Jun 10, 2016
@Godin Godin force-pushed the obsolete-links branch 2 times, most recently from 084a979 to 8d5b3e0 Compare June 11, 2016 10:42
@Godin
Copy link
Member Author

Godin commented Jun 11, 2016

@marchof could you please review?

@@ -55,11 +53,7 @@ <h1 style="clear:left">Resources</h1>
<h2>Articles About EclEmma</h2>

<ul>
<li>Tests f&uuml;r die Tests by Marc R. Hoffmann, <a class="extern" href="http://it-republik.de/jaxenter/eclipse-magazin-ausgaben/Android-000442.html">Eclipse Magazin Vol. 3.2011</a>, 2011/03/25 [de]</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these paper publications still exist I wouldn't remove them from the list. Just the web links should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof makes sense, fixed

<li><a class="extern" href="http://agile.csc.ncsu.edu/SEMaterials/tutorials/eclemma/">Test Coverage with EclEmma</a> by Laurie Williams, Ben Smith and Sarah Heckman, <a class="extern" href="http://www.ncsu.edu/">North Carolina State University</a>, 2009/03/30</li>
<li>Testabdeckung mit Open-Source-Tools by Tim Wellhausen, <a class="extern" href="http://www.sigs-datacom.de/sd/publications/js/2008/06/index.htm">JavaSpektrum</a>, 2008/06/01 [de]</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also JavaSpektum is a printed magazine, so I prefer to keep the reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof fixed

@marchof
Copy link
Member

marchof commented Jun 11, 2016

@Godin Thanks!

@marchof marchof merged commit db32585 into master Jun 11, 2016
@marchof marchof deleted the obsolete-links branch June 11, 2016 11:05
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants