AsyncIterator _end race condition workaround #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a race condition in AsyncIterator, which arises during my unit tests, in which
_end
is called on theLevelIterator
twice, asynchronously from:The outcome in node-quadstore is that the LevelDown
AbstractIterator
is ended twice, which throws the second time.I have yet to reproduce this problem either in node-quadstore or in base AsyncIterator.
cc @RubenVerborgh, just in case the cause is obvious.