Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging sources priority bugs left nav bar #850

Closed
3 of 10 tasks
Nightenom opened this issue Jun 19, 2022 · 3 comments
Closed
3 of 10 tasks

Dragging sources priority bugs left nav bar #850

Nightenom opened this issue Jun 19, 2022 · 3 comments
Labels
bug confirmed A bug that has successfully been replicated and can be resolved

Comments

@Nightenom
Copy link

Nightenom commented Jun 19, 2022 •
edited
Loading

Iris version

3.63 to 3.64.0

Operating system(s) affected

  • Windows
  • MacOS
  • iOS
  • Android
  • Linux
  • Other

Browser(s) affected

  • Firefox
  • Chrome
  • Edge
  • Other

What happened?

Dragging/sorting sources priority in settings permanently changes the left nav bar to quick song actions.
Reproducibility 100%, reloading the page fixes it.

Logs

No response
@Nightenom Nightenom added the bug label Jun 19, 2022
@WallyDW
Copy link

WallyDW commented Jun 23, 2022 •
edited
Loading

Add firefox to this too
And version 3.63 too.

@jaedb jaedb added the confirmed A bug that has successfully been replicated and can be resolved label Jul 23, 2022
@jaedb
Copy link
Owner

jaedb commented Aug 21, 2022 •
edited
Loading

Due to a conflict between react-dnd and react-sortable. Can be resolved by upgrading SourcesPriority component to use react-dnd.

The same is the case for the Commands component.

@jaedb
Copy link
Owner

jaedb commented Sep 3, 2022 •
edited
Loading

Removing sources priority entirely; this is a buggy logic and I would rather have fewer features working really well then loads of features that don't. Commands component upgraded to react-dnd in ae3b831

Will be included in next release.

@jaedb jaedb closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed A bug that has successfully been replicated and can be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaedb @Nightenom @WallyDW