[jaeger-operator] Refactor CRD to allow Jaeger CR creation on initial install

[mjnagel]

Signed-off-by: Micah Nagel micah.nagel@parsons.com

What this PR does

#368 moved the CRD out of the special chart/crds helm chart folder and into chart/crd. While this did result in the chart making use of the already existing chart/templates/crd.yaml template to install the CRD, the other result is that you must install the helm chart without jaeger.create set to true, then upgrade after the CRD has been installed. If we make use of the chart/crds folder as recommended by the first method here then the CRDs are installed before Helm applies the other manifests.

This unknowingly introduced what I would consider a breaking change into the chart - you now are required to install the operator separately from the Jaeger CR (install then upgrade).

Fixes #373

Checklist

• DCO signed
• Commits are GPG signed
• Chart Version bumped
• Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
• README.md has been updated to match version/contain new values

[mjnagel]

The biggest downside of moving this to the crds folder is that Helm templating is not supported. My understanding is that the labels/annotations added in the previous PR are not functionally necessary so this is not an issue, but if those are required the issue is trickier.

An alternative I have seen if we want the best of both worlds (helm templating in the CRD + installs with jaeger.create): a pre-install / pre-upgrade job that mounts a configmap with the CRDs and applies them against the cluster. Would be more of a lift and introduce a new dependency on a kubectl image, but I could modify this PR if that seems like a better route.

[batazor]

@czomo Maybe we should put crd.yaml back in the crds folder?

[czomo]

I completely missed that use case cause I tested it on already updated CRD/existing cluster. Thanks for pointing this out. Yes, we should move it back to crds

[czomo]

@mjnagel Let's squash it
@batazor Would you like to look at it as code owner? Thanks

[mjnagel]

@czomo can do, should I also update to a new patch version since #371 was merged?

[czomo]

@czomo can do, should I also update to a new patch version since #371 was merged?

Yes, indeed. Rebase and squash is all we need 🚀

[mjnagel]

Yes, indeed. Rebase and squash is all we need 🚀

Should be good to go!