Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-operator] Breaking change to Jaeger CR creation in 2.31.0+ #373

Closed
mjnagel opened this issue Jun 7, 2022 · 0 comments · Fixed by #372
Closed

[jaeger-operator] Breaking change to Jaeger CR creation in 2.31.0+ #373

mjnagel opened this issue Jun 7, 2022 · 0 comments · Fixed by #372
Labels
bug Something isn't working

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Jun 7, 2022

Describe the bug

#368 moved the CRD out of the special chart/crds helm chart folder and into chart/crd. While this did result in the chart making use of the already existing chart/templates/crd.yaml template to install the CRD, the result is that you must install the helm chart without jaeger.create set to true, then upgrade after the CRD has been installed.

If we make use of the chart/crds folder as recommended by the first method here then the CRDs are installed before Helm applies the other manifests. There are other options as well including a pre-install/upgrade job that would apply the CRDs if we need conditional CRD creation or helm templating inside the CRD.

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to install the helm chart with jaeger.create: true.
  2. Helm install will fail due to CRD not existing.

Expected behavior

All values provided in the chart, such as the ability to install a Jaeger CR with the operator, should be supported.

Version (please complete the following information):

  • OS: [e.g. Linux]: MacOS
  • Jaeger version: [e.g. 1.8]: Chart 2.31.0
  • Deployment: [e.g. bare metal, Docker, Kubernetes, ...]: k3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant