Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded jaeger path #11

Closed
EinKrebs opened this issue Jul 15, 2021 · 3 comments · Fixed by #12
Closed

Hardcoded jaeger path #11

EinKrebs opened this issue Jul 15, 2021 · 3 comments · Fixed by #12

Comments

@EinKrebs
Copy link
Member

Make considers path to jaeger all-in-one as ${HOME}/projects/jaegertracing/jaeger/cmd/all-in-one/all-in-one-linux-amd64, maybe it's better to make environmental variable for this

@pavolloffay
Copy link
Member

The path is configurable like the readme says https://github.com/pavolloffay/jaeger-clickhouse#run

@pavolloffay
Copy link
Member

We should change the run command to run Jaeger all-in-one from docker and inject the compiled plugin via volume.

@pavolloffay
Copy link
Member

Something like this could work, but it doesn't. I didn't dig into it.

.PHONY: run
run:
	docker run --rm -it -u ${shell id -u} -v "${PWD}:/data" -e SPAN_STORAGE_TYPE=grpc-plugin jaegertracing/all-in-one:1.24.0 --grpc-storage-plugin.binary=/data/jaeger-clickhouse-$(GOOS)-$(GOARCH) --grpc-storage-plugin.configuration-file=/data/config.yaml
	#SPAN_STORAGE_TYPE=grpc-plugin ${JAEGER_ALL_IN_ONE} --grpc-storage-plugin.binary=./jaeger-clickhouse-$(GOOS)-$(GOARCH) --grpc-storage-plugin.configuration-file=./config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants