Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace - Indent guides in span-name column to indicate span ancestry #172

Closed
tiffon opened this issue Jan 21, 2018 · 2 comments
Closed

Trace - Indent guides in span-name column to indicate span ancestry #172

tiffon opened this issue Jan 21, 2018 · 2 comments
Assignees

Comments

@tiffon
Copy link
Member

tiffon commented Jan 21, 2018

It may be helpful to test some of these designs with applications that have many internal spans. The hot rod application doesn't have too many levels of indentation and uses several different "application tracers" resulting in spans that are more visually legible. Here is a short segment from a trace in our infra::

image

Since everything is in the same service and there are several levels of indentation, it is very hard to see what elements are children of the others.

A couple suggestions:

  1. Add guidelines down each indentation level like code editors do for whitespace
    image

  2. When a parent is hovered, every element that is a child of that element should have some sort of hover state. At the very least, the first and last child should have some marker. I would suggest just extending that hover state down to cover its children (mockup based on posted screenshots):
    image

Aside from that, the screenshots posted here look great.

The approach that initially comes to mind is to have low-contrast, persistent indent guides visible at all times and to highlight the relevant indent guides on hover (e.g. ancestors of the span the mouse is over). In the screenshot below, the all of the indent guides of the return statement and subsequent lines would still be visible, but they would be the low-contrast variation instead of emphasized with orange.

screen shot 2018-01-21 at 3 37 38 pm

@black-adder
Copy link
Contributor

+1 for guidelines

@tiffon tiffon assigned tiffon and unassigned tiffon Feb 1, 2018
@tiffon tiffon added the backlog label Apr 3, 2018
@tiffon tiffon removed the outreachy label Sep 3, 2018
@everett980 everett980 self-assigned this Dec 18, 2018
everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 18, 2018
Signed-off-by: Everett Ross <reverett@uber.com>
tiffon pushed a commit that referenced this issue Jan 4, 2019
* Add indent guides to trace timeline view (#172)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add tests for connect functions, add more flow types

Signed-off-by: Everett Ross <reverett@uber.com>

* Consolidate ducks, remove redudant PropTypes, add event type

Signed-off-by: Everett Ross <reverett@uber.com>

* Rename hoverSpanId to hoverIndentGuideId

Signed-off-by: Everett Ross <reverett@uber.com>

* Derive props from span, use dataset over getAttribute

Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Jan 16, 2019
…racing#297)

* Add indent guides to trace timeline view (jaegertracing#172)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add tests for connect functions, add more flow types

Signed-off-by: Everett Ross <reverett@uber.com>

* Consolidate ducks, remove redudant PropTypes, add event type

Signed-off-by: Everett Ross <reverett@uber.com>

* Rename hoverSpanId to hoverIndentGuideId

Signed-off-by: Everett Ross <reverett@uber.com>

* Derive props from span, use dataset over getAttribute

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@tiffon
Copy link
Member Author

tiffon commented Mar 7, 2019

Fixed in #297.

@tiffon tiffon closed this as completed Mar 7, 2019
@ghost ghost removed the backlog label Mar 7, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
…racing#297)

* Add indent guides to trace timeline view (jaegertracing#172)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add tests for connect functions, add more flow types

Signed-off-by: Everett Ross <reverett@uber.com>

* Consolidate ducks, remove redudant PropTypes, add event type

Signed-off-by: Everett Ross <reverett@uber.com>

* Rename hoverSpanId to hoverIndentGuideId

Signed-off-by: Everett Ross <reverett@uber.com>

* Derive props from span, use dataset over getAttribute

Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
…racing#297)

* Add indent guides to trace timeline view (jaegertracing#172)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add tests for connect functions, add more flow types

Signed-off-by: Everett Ross <reverett@uber.com>

* Consolidate ducks, remove redudant PropTypes, add event type

Signed-off-by: Everett Ross <reverett@uber.com>

* Rename hoverSpanId to hoverIndentGuideId

Signed-off-by: Everett Ross <reverett@uber.com>

* Derive props from span, use dataset over getAttribute

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants