Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent metrics are not tagged #850

Closed
yurishkuro opened this issue May 29, 2018 · 4 comments
Closed

Agent metrics are not tagged #850

yurishkuro opened this issue May 29, 2018 · 4 comments

Comments

@yurishkuro
Copy link
Member

Post #776 some metrics are still path based, these are the ones I found:

jaeger_agent_tc_reporter_jaeger_batch_size 0
jaeger_agent_tc_reporter_jaeger_batches_failures 0
jaeger_agent_tc_reporter_jaeger_batches_submitted 0
jaeger_agent_tc_reporter_jaeger_spans_failures 0
jaeger_agent_tc_reporter_jaeger_spans_submitted 0
jaeger_agent_tc_reporter_zipkin_batch_size 0
jaeger_agent_tc_reporter_zipkin_batches_failures 0
jaeger_agent_tc_reporter_zipkin_batches_submitted 0
jaeger_agent_tc_reporter_zipkin_spans_failures 0
jaeger_agent_tc_reporter_zipkin_spans_submitted 0

The jaeger/zipkin should be pulled into format tag

@jpkrohling
Copy link
Contributor

I believe the client is also not following the same idea.

@yurishkuro
Copy link
Member Author

client seems ok to me, but please open another ticket with examples if not

@eundoosong
Copy link
Contributor

@yurishkuro So, above metrics should look like this?

jaeger_agent_tc_reporter_batch_size{format="jaeger"}

I think a few lines of codes are required to be changed to fix this.
If it's ok I'll PR.

@yurishkuro
Copy link
Member Author

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants