Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending project with GitHub Actions (CI) #19

Closed
szolkowski opened this issue Aug 2, 2021 · 3 comments
Closed

Extending project with GitHub Actions (CI) #19

szolkowski opened this issue Aug 2, 2021 · 3 comments

Comments

@szolkowski
Copy link
Contributor

szolkowski commented Aug 2, 2021

Hello,

I wanted to learn GitHub Actions and used my fork of this project as playground. I think it can be also added to main project since it is always good to have CI working for projects. I prepared them just for NETStandard part, since it is where tests are.

You can take a look how it looks like I my fork:

https://github.com/Stanislaw000/ONIX-Data/actions

PR: szolkowski#6 (you need to click on show details box).

image

Tests results: https://github.com/Stanislaw000/ONIX-Data/runs/3182479870?check_suite_focus=true

Workflow files are in pull request #18

If you prefer to change something or customize let me know, so we can improve this solution.

@jaerith
Copy link
Owner

jaerith commented Aug 2, 2021

Good idea! I had also planned on checking those out at some point. Looks like you're way ahead of me. :)

@jaerith
Copy link
Owner

jaerith commented Aug 2, 2021

Question: Is the "Test Report" being run twice, once at the end of the CI step (i.e., at the bottom of ci.yml) and then as a trigger once the CI step completes (i.e., test-report.yml)?

@szolkowski
Copy link
Contributor Author

It isn't - it will be run on default branch only( I am assuming this, since I didn't want to mess up my fork by switching default branches between master and NetStandard). I was using recommended setup for public repository based on "Test reporter" action recommendation: https://github.com/dorny/test-reporter

@jaerith jaerith closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants