Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Price.Territory.CountriesIncluded #9

Closed
dgil-unedbarbastro opened this issue Jun 10, 2021 · 4 comments
Closed

Missing Price.Territory.CountriesIncluded #9

dgil-unedbarbastro opened this issue Jun 10, 2021 · 4 comments

Comments

@dgil-unedbarbastro
Copy link
Contributor

Hi,

I'm trying to filter the price list by country using the field Territory.CountriesIncluded:

image

but I'm not able to find it.

When I inspect the OnixData.Version3.Price.OnixPrice object and I can't find it:

image

Am I searching in the wrong place?

Regards,
Dani

@jaerith
Copy link
Owner

jaerith commented Jun 10, 2021

Hi Dani! Yes, currently that tag is not yet supported by the parser, but it's easy enough to implement. I'll try to do so in the near future.

FYI - this project supports many tags within the ONIX standard, but it doesn't yet support all of them. The scope and complexity of ONIX 3.0 is a bit overwhelming at times.

@jaerith
Copy link
Owner

jaerith commented Jun 10, 2021

I added Territory as a property of the Price composite. Let me know if it works for you!

@dgil-unedbarbastro
Copy link
Contributor Author

Thanks @jaerith works great.

I was using your nuget ONIX-Data (v0.5.0) from the Nuget Package Manager, and for this test I've cloned your repo and I've added the OnixData project to my solution as existing project. Will you update the nuget?

@jaerith
Copy link
Owner

jaerith commented Jun 11, 2021

Actually, the package was overdue for an update. The new version 0.5.1 is now available.

@jaerith jaerith closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants