Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Connect URLs #3

Closed
wants to merge 1 commit into from
Closed

Update Connect URLs #3

wants to merge 1 commit into from

Conversation

jmsfwk
Copy link

@jmsfwk jmsfwk commented Aug 9, 2021

No description provided.

@byt3sage
Copy link
Owner

This should probably be a config variable placed in the .env file. Did you want to do that or would you prefer me to push that up?

@jmsfwk
Copy link
Author

jmsfwk commented Aug 10, 2021

I'll have a look

@byt3sage byt3sage self-requested a review August 10, 2021 10:59
byt3sage
byt3sage requested changes Aug 10, 2021
View reviewed changes
Copy link
Owner

@byt3sage byt3sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment - this would be better placed in the env file with a config.

@jmsfwk jmsfwk closed this Sep 9, 2021
@jmsfwk jmsfwk deleted the patch-1 branch September 9, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byt3sage byt3sage byt3sage requested changes

Assignees

@jmsfwk jmsfwk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmsfwk @byt3sage