Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERRO[0000] Failed to create a file for article titled #4

Closed
bl00dy1837 opened this issue Nov 20, 2022 · 2 comments · Fixed by #8
Closed

ERRO[0000] Failed to create a file for article titled #4

bl00dy1837 opened this issue Nov 20, 2022 · 2 comments · Fixed by #8
Labels
good first issue Good for newcomers

Comments

@bl00dy1837
Copy link
Contributor

I tested some RSS feeds. The feed https://blog.fefe.de/rss.xml is mostly failing.
Maybe to long or wrong encoding? Didn't dive into the code yet 😄 .

@jafarlihi
Copy link
Owner

Thanks for reporting. I'll look into it sometime within this week.

@mattpep
Copy link
Contributor

mattpep commented Nov 27, 2022

This was caused by the long title in this feed - it's exceeding filesystem limits and so the os.Create() call fails.

I've raised an MR to fix this, and included some simple tests with it too.

The approach I'm taking is an arbitrary split (at the length limit) rather than splitting on a whitespace boundary. I'll amend my patch if you feel it would be better to truncate at a word break instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants