use type assertions instead of reflect #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can type-assert to interfaces, even in cases where this is "upgrading" to a more-restrictive interface which needs additional fields, as long as the underlying concrete type implements the interface. I wasn't 100% sure about this, but I did some test cases and it worked. (Then it failed because my copy of spf13/pflag was too old to handle IP masks, but updating it fixed that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can type-assert to interfaces, even in cases where
this is "upgrading" to a more-restrictive interface which
needs additional fields, as long as the underlying concrete
type implements the interface.
I wasn't 100% sure about this, but I did some test cases
and it worked. (Then it failed because my copy of spf13/pflag
was too old to handle IP masks, but updating it fixed that.)