Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fix #1055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Grammar fix #1055

wants to merge 2 commits into from

Conversation

lorivaro
Copy link
Contributor

@lorivaro lorivaro commented Nov 26, 2021

This pull request...

  • Fixes a bug
  • Introduces a new feature
  • Improves an existing feature
  • Boosts code quality or performance

Description

In this PR I have made very minor changes, improving the overall grammar of the bot's responses.
Here are a few examples, version 0.3.6 being on top and this PR's below.

1 entries1 entry
image
image

1 items1 item
image

1 entries1 entry
image
image

Purpose

Saying 1 entry instead of 1 entries just makes more sense. (grammar duh)
Anything else than 1 entry like 2 entries will of course remain as 2 entries.
This seemed like a small thing I thought I would be able to fix.

@lorivaro
Copy link
Contributor Author

Let me know if I missed a spot.

@lorivaro lorivaro changed the title Minor enhancement Grammar fix Nov 26, 2021
@jagrosh jagrosh added the on hold label Jan 4, 2022
@jagrosh
Copy link
Owner

jagrosh commented Jan 4, 2022

While this does resolve some grammar issues, I think that everything in this PR will end up getting overwritten when we add localization, which will utilize resource bundles and do plurals like this: https://docs.oracle.com/javase/tutorial/i18n/format/choiceFormat.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants