Catch JDA exception when there is no internet connection #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the bot try to reconnect on error (with a delay)? |
|
Did you try building and testing this? It is failing to build with CI |
|
It's missing |
Yeah that's my mistake, I've added it in and tested on my machine. I have a systemd service that will now automatically restart on failure. |
ElerWohlmuthFH
pushed a commit
to ElerWohlmuthFH/MusicBot
that referenced
this pull request
Sep 20, 2024
Catch JDA exception when there is no internet connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
Added catch clause to JMusicBot.java
Purpose
When running the bot without an internet connection, the JDA connection attempt will fail without catching the exception and doing a proper system exit. This means that if the bot cannot establish a connection, the program will wait instead of exiting. Automated restart scripts will not work as a result.
Relevant Issue(s)
This PR closes issue #1303