Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Compose Multiplatform? #32

Closed
sunny-chung opened this issue Mar 8, 2024 · 3 comments
Closed

Support Compose Multiplatform? #32

sunny-chung opened this issue Mar 8, 2024 · 3 comments

Comments

@sunny-chung
Copy link

Would you support Compose Multiplatform?

I just have a quick look on the source code. It seems the core does not depend on Android-specific stuffs, so it might not be difficult. If you have no time, would you accept a PR?

@jaikeerthick
Copy link
Owner

Hey @sunny-chung, Thank you for your interest in Composable Graphs library. Yes the library doesn't depend on Android-specific things. Adding support for Compose Multiplatform sounds like a valuable addition, and I appreciate your willingness to contribute.

I'm open to accepting a pull request (PR) for this feature if you're willing to work on it. Feel free to go ahead and submit a PR whenever you're ready. If you have any questions or need guidance along the way, don't hesitate to ask. Your contribution to the project is greatly appreciated!

@sunny-chung
Copy link
Author

I can do that, but there will be a breaking change for you. Jitpack does not build Apple OS artifacts. To support multiplatform, perhaps you would have to move to Maven Central, which requires you to changing the library group ID to "io.github.jaikeerthick".

@jaikeerthick
Copy link
Owner

I understand the requirements and challenges to migrate to KMM. The library still need to mature a lot and therefore I'm planning to not to support KMM as of now and I promise that the library will continue to have pure kotlin code and no Android-specific dependencies so that in future It'll be easy to support KMM.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants