Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests to disabling thrown of FailingHttpStatusCode exception #399

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

breakponchito
Copy link
Contributor

The tests fixed here were designed to validate error page response. On some servers this is causing to thrown the FailingHttpStatusCode exception causing to fail the tests (Payara server is an example). This PR is to disable this behaviour that is part of the HtmlUnit implementation. This will help some servers to pass TCK by omitting the FailingHttpStatusCode exception

challenge created

@manovotn
Copy link
Contributor

Fixes #389

@manovotn manovotn requested a review from Ladicek July 19, 2022 12:02
@Ladicek
Copy link
Contributor

Ladicek commented Jul 19, 2022

LGTM, but I don't know what's the proper workflow when it comes to TCK challenges or so, so I'll leave that to you @manovotn :-)

@manovotn
Copy link
Contributor

I am not familiar with the flow from docs either, but I'd just go with making another release as we have this plus one other fix present already. Scott would know for sure but I think he's out of office now.

Also, as I stated in the issue, I don't think this is actually a valid challenge per se because the test doesn't care what's the HTTP status code returned. The test also exists for a long time in unchanged manner and I think what's causing these issues to emerge is a tooling upgrade done in 0f9f0a4
Htmlunit now defaults to throwing an error where it was previously silently ignoring it.

So while not a challenge to what we assert, it is definitely a ground for improvement.

@manovotn manovotn merged commit 5393d67 into master Jul 19, 2022
@manovotn manovotn deleted the Prevent_thrown_of_FailingHttpStatusCode_exception branch July 19, 2022 13:13
@Ladicek
Copy link
Contributor

Ladicek commented Jul 19, 2022

Okay gotcha. This is a simple bugfix then. Makes sense.

@breakponchito
Copy link
Contributor Author

thank you guys to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants