fix test that interceptors are dependent instances of intercepted beans #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test previously used a `@PreDestroy` callback declared on the interceptor to prove that the interceptor is destroyed when the intercepted bean is destroyed, which is incorrect. Interceptors cannot declare lifecycle callbacks for themselves, the `@PreDestroy` callback actually interposed on the destruction of the intercepted bean. This commit uses a new dependent-scoped bean that is injected into the interceptor, which makes it a dependent instance of the interceptor. The new bean has a `@PreDestroy` callback for itself, which means we can verify that the new bean is destroyed when the intercepted bean is destroyed. Such chain of dependent instance destruction proves that the interceptor is indeed a dependent instance of the intercepted bean.
|
Draft until #454 is accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test previously used a
@PreDestroycallback declared on the interceptor to prove that the interceptor is destroyed when the intercepted bean is destroyed, which is incorrect. Interceptors cannot declare lifecycle callbacks for themselves, the@PreDestroycallback actually interposed on the destruction of the intercepted bean.This commit uses a new dependent-scoped bean that is injected into the interceptor, which makes it a dependent instance of the interceptor. The new bean has a
@PreDestroycallback for itself, which means we can verify that the new bean is destroyed when the intercepted bean is destroyed. Such chain of dependent instance destruction proves that the interceptor is indeed a dependent instance of the intercepted bean.Fixes #454