Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite/Full split: finish preface #490

Closed
Ladicek opened this issue May 20, 2021 · 5 comments · Fixed by #538
Closed

Lite/Full split: finish preface #490

Ladicek opened this issue May 20, 2021 · 5 comments · Fixed by #538
Assignees
Labels
Lite Related to CDI Lite

Comments

@Ladicek
Copy link
Contributor

Ladicek commented May 20, 2021

https://github.com/eclipse-ee4j/cdi/blob/864e1b4f779e4d6d5a80f147d975a510446d4987/spec/src/main/asciidoc/preface.asciidoc

@manovotn
Copy link
Contributor

manovotn commented Oct 7, 2021

@Ladicek @starksm64 do we have an idea of what should this preface actually contain? The comment mentions "history of spec" but I am not sure what is that supposed to mean.
Former releases such as CDI 2 or CDI 3 didn't have any preface and just listed spec name, version and release date.

@Ladicek
Copy link
Contributor Author

Ladicek commented Oct 7, 2021

I don't know what that "consistent history of the spec" is supposed to mean, either. I think @antoinesd added that note?

@antoinesd
Copy link
Contributor

Yes, I added that note. It was more to complete the history than to make it consistent. We can let it like that IMHO

@manovotn
Copy link
Contributor

manovotn commented Oct 8, 2021

Ok, in that case, I'll remove the TODO and keep the document as it was.

@Ladicek
Copy link
Contributor Author

Ladicek commented Oct 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lite Related to CDI Lite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants