CDI: Allow listing to PhaseEvents via @Observes

[eclipse-faces-bot]

DeltaSpike has a way to catch PhaseEvents via @Observes:
https://deltaspike.apache.org/documentation/jsf.html#Eventbroadcasting
See AfterPhase / BeforePhase

It would be great to have this, however this requires that PhaseId values are Enums.

Example:

public void onPhaseStart(@Observes @BeforePhase(PhaseId.ANY_PHASE) PhaseEvent event) {
    //...
}

public void onPhaseEnd(@Observes @AfterPhase(PhaseId.RENDER_VIEW) PhaseEvent event) {
    //...

[tandraschko]

Easy implemented prototype here: tandraschko/myfaces@63a3fe8

please review @BalusC @arjantijms @pizzi80 @melloware

[melloware]

This looks good I have used my own custom one for years!

[BalusC]

Oh cool. Let's do it for 5.0. I like you took the opportunity to finally turn the PhaseId into an enum.

[tandraschko]

done in myfaces: apache/myfaces@c30922c

[tandraschko]

i really like how easy those both CDI enhancements was to implement and its a great benefit for users

[BalusC]

@tandraschko how about ANY_PHASE and the firing order relative to existing phase listeners? Is the behavior as documented in https://github.com/jakartaee/faces/pull/1965/files and as asserted by this integration test acceptable/intuitive? https://github.com/jakartaee/faces/pull/1966/files#diff-6df6ff3e53a0b081d16b1becf2816939412c977ce2d9e20d1b93e35524933255R38

[tandraschko]

The order is a good question; i didnt care about it and just registered it in the jsf-impl faces-config.xml