Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing Specification meeting minutes for October. #951

Merged

Conversation

TanjaObradovic
Copy link
Contributor

Please merge this as soon as you can. Thanks!

@netlify
Copy link

netlify bot commented Nov 15, 2020

Deploy preview for jakartaee ready!

Built with commit b775af0

https://deploy-preview-951--jakartaee.netlify.app

Copy link
Contributor

@ericpoirier ericpoirier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tanja,

Here are a few comments that will need to be looked at before we can merge your PR.

Thanks.

data/meeting_minutes.yml Outdated Show resolved Hide resolved
title: October 17, 2020 (pdf)
year: 2020
-
url: specification_committee/minutes-specification-october-7-2020.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo in the actual name of your file. There's an extra space
"minutes-specification-october- 7-2020.pdf"

You will have to update the name of your file.

Signed-off-by: Tanja Obradovic <tanja.obradovic@eclipse-foundation.org>
Signed-off-by: Tanja Obradovic <tanja.obradovic@eclipse-foundation.org>
Signed-off-by: Tanja Obradovic <tanja.obradovic@eclipse-foundation.org>
@chrisguindon chrisguindon merged commit 82d2a2e into jakartaee:src Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants