Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency 3.1 - Add virtual and qualifier elements to resource definitions #44

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Dec 5, 2023

Fixes #43

NOTE: testing locally and via GitHub actions resulted in the following error:

      [java] testing application-concurrency.xml
     [java] sax error: 46:cvc-complex-type.2.4.a: Invalid content was found starting with element 'virtual'. One of '{"https://jakarta.ee/xml/ns/jakartaee":qualifier, "https://jakarta.ee/xml/ns/jakartaee":property}' is expected.
     [java] sax error: 53:cvc-complex-type.2.4.a: Invalid content was found starting with element 'virtual'. One of '{"https://jakarta.ee/xml/ns/jakartaee":qualifier, "https://jakarta.ee/xml/ns/jakartaee":property}' is expected.
     [java] sax error: 65:cvc-complex-type.2.4.a: Invalid content was found starting with element 'virtual'. One of '{"https://jakarta.ee/xml/ns/jakartaee":qualifier, "https://jakarta.ee/xml/ns/jakartaee":property}' is expected.
     [java] found 3 error(s)

Not sure what this failure means. If someone more familiar with this project could point me in the right direction it would be appreciated.

(Also weird that errors don't cause build breaks 馃し馃徏 )

</context-service>

<managed-executor>
<name>java:app/concurrent/Executor20</name>
<context-service-ref>java:app/concurrent/SecContextOnly</context-service-ref>
<max-async>20</max-async>
<qualifier>ee.jakarta.MyQualifier</qualifier>
<qualifier>ee.jakarta.MyQualifier2</qualifier>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering of the elements in the application_11.xsd for the managed-executorType has the virtual element before the qualifier element, which is why you are seeing validation errors.

@KyleAure
Copy link
Contributor Author

KyleAure commented Dec 6, 2023

@starksm64 thanks for catching that! I updated the test to have elements in the correct order.

I also updated the web-app-concurrency test which required me to copy/rename the web-app related schemas.

I also want to update the ejb-jar-concurrency test, which would mean we'd have to update the ejb-jar schema to change the following to EE 11:

<xsd:include schemaLocation="jakartaee_9.xsd"/>

However there are no new versions of EJB for EE 10/11, so how can embedded resources within this schema be included?
As it stands right now the ejb-jar-concurrency test is failing with 125 errors because it includes elements from EE 10 that the schema doesn't include.

Reading some more issues it seems the determination is that EJB schema is frozen at EE 9. Therefore I removed the ejb-jar-concurrency test because it is invalid.

FYI @tbitonti - This may be of interest to you based on your issue #32

@starksm64
Copy link
Contributor

I also want to update the ejb-jar-concurrency test, which would mean we'd have to update the ejb-jar schema to change the following to EE 11:

<xsd:include schemaLocation="jakartaee_9.xsd"/>

However there are no new versions of EJB for EE 10/11, so how can embedded resources within this schema be included? As it stands right now the ejb-jar-concurrency test is failing with 125 errors because it includes elements from EE 10 that the schema doesn't include.

Reading some more issues it seems the determination is that EJB schema is frozen at EE 9. Therefore I removed the ejb-jar-concurrency test because it is invalid.

FYI @tbitonti - This may be of interest to you based on your issue #32

So we won't be able to update the ejb-jar-concurrency.xml test since we don't have any updated schema and there will be no requirements for EJB containers to support the new environments.

@njr-11
Copy link
Contributor

njr-11 commented Dec 12, 2023

We should consider positioning the new qualifier element right after name. It might make sense to have this be more prominent in the configuration because it covers how applications reference/access these resources.

@KyleAure
Copy link
Contributor Author

KyleAure commented Jan 3, 2024

@ivargrimstad @starksm64 anything else I need to do to get this PR reviewed/approved?

@starksm64 starksm64 merged commit bf95260 into jakartaee:master Jan 3, 2024
3 checks passed
@KyleAure KyleAure deleted the concurrenty-3.1-updates branch January 3, 2024 20:03
KyleAure added a commit to KyleAure/jakartaee-schemas that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrency 3.1 - Add virtual and qualifier elements to resource definitions
3 participants