Forgot to update web-fragment #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily-Jiang
reviewed
Jan 25, 2024
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
|
|
||
| Copyright (c) 2009, 2024 Oracle and/or its affiliates and others. |
There was a problem hiding this comment.
Is this a correct copyright? I thought this is a new file. Should we use the copyright like:
Copyright (c) 2024 Contributors to the Eclipse Foundation
There was a problem hiding this comment.
I just duplicated the 6_0 version and updated the imports/versions... In that case I would think the copyright history would follow.
There was a problem hiding this comment.
ah, okay. Thanks for explaining this!
|
@starksm64 - review for review. |
|
Closing duplicate of #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to create a 6.1 version of web-fragment in #44