-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing operators in DocumentCondition #99
Comments
We have the negate negate method to Not operator. |
I've created this PR to add the no method following the Java API: |
oh ! that's good enough, sorry. I missed that. Point n1 is to be considered fixed. |
@otaviojava correcly integrated on the fly ! |
@otaviojava what bout point n2 and n3 ? how can we proceed ? |
Hi @otaviojava ! |
Sorry for the delay. So, what we can do is create some utilitarian classes to cover it. What do you think? |
I can't really understand which are the functionalities to be modeled in jakarta-data that we may cover/use here. Let's just not forget the final goal : having a complete query builder for JNoSql, with update and delete support too ! Now, what do we do ? |
How about improving the MongoDB extension? What do you think if we move it as a dependency in build time? |
Maybe we can have a call and talk about this ? I added these two new dependencies :
Are talking about both of them ? |
Anyway yes @otaviojava, auto-service can be flagged as a compile time only dependency. |
Yeap, if we put those as an option it would be really nice. |
@otaviojava here you are : BUT we can't flag com.sun.codemodel as optional, it is a required transitive dependency. What do you think ? |
I like it. Cassandra Mapper has a similar strategy with an annotation processor: https://docs.datastax.com/en/developer/java-driver/4.2/manual/mapper/config/ |
At the beginning, when my code was still in the main jnosql api and impl libraries, metamodel generator was indeed already a separate library. Inside mapping extensions, how do you suggest to proceed ? Maybe a 'jnosql-metamodel-generator-extension' ? |
I like the |
@otaviojava is this good ? |
Hi @otaviojava I would like to start moving criteria packages to jnosql-criteria-extension but I need to know what you think about it |
Hey @amoscatelli, we removed the communication here. So, I'll close this one. |
Hi @otaviojava
Let's keep track of the missing operators / functionalities to extend yours DocumentCondition (#90) with :
'Not' operator. Basic negation operator, I believe every nosql databases supports it (for sure it's supported by MongoDB and ElasticSearch).
InclusiveBetween + ExclusiveBetween VS Between. Same as before, also we already talked about this.
Allowing a 'path' on the 'Right hand side'. This is the hardest one, we need to find a way to represent a 'path' and allowing DocumentCondition operators to accept that path as a RHS. For example this allows making queries like 'retrieve every movie where critics score is higher than odience score'. You told me this is not supported at the moment so we need to work on this. If I recall correctly, both mongodb and elasticsearch support this out of the box.
What do you think ?
The text was updated successfully, but these errors were encountered: