Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has a problem with negative numbers #3

Closed
andy4us opened this issue Jul 2, 2016 · 2 comments
Closed

Has a problem with negative numbers #3

andy4us opened this issue Jul 2, 2016 · 2 comments

Comments

@andy4us
Copy link

andy4us commented Jul 2, 2016

I'm using it under node. It works fine for "8 1/2" and returns 8.5. Using "-8 1/2" it is returning -1. I was expecting "-8.5"
@jakeboone02
Copy link
Owner

Yeah, that was on purpose because it was originally for handling recipe quantities, where negative numbers don't make sense. That's why errors return -1. It was an easy hack.

If you feel like submitting a PR to fix it I'd be happy to consider it. I won't be near a computer for a few days, so if you can wait I may take a look next week some time.

@jakeboone02
Copy link
Owner

This is fixed in v0.5.0.

@jakeboone02 jakeboone02 changed the title Has a problem with -ve numbers Has a problem with negative numbers Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakeboone02 @andy4us