Fix issue where command before level 1 heading was ignored #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command before the level 1 heading wasn't being pushed into the array of commands (line 26 in the parser). However, after the parser is done, the last command is correctly added to the list of commands. So I decided that if we see another level one heading within the document, the parser should stop (break) there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command before a level 1 heading wasn't being pushed into the array of commands (line 26 in the parser).
However, after the parser is done, the last command was correctly being added to the list of commands. The problem was that when a level 1 heading is found, that last command is overwritten and lost.
Which issue does this fix?
Closes #75
Describe the solution
I decided that if we see another level 1 heading within the document, the parser should stop (break) there. Anything below that level 1 heading will be ignored... so that might be a good place to put documentation or other content.