Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for table with external borders but no inner borders for top/bottom #13

Closed
onilton opened this issue Jan 5, 2020 · 3 comments · Fixed by #14
Closed

Support for table with external borders but no inner borders for top/bottom #13

onilton opened this issue Jan 5, 2020 · 3 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@onilton
Copy link

onilton commented Jan 5, 2020

Picnic could be able to do build

┌───────────┬──────────────┐
│ columnA   │ columnB      │
├───────────┼──────────────┤
│ itemA1    │ B            │
│ itemA2    │ C            │
│ itemA3    │ D            │
└───────────┴──────────────┘

But right now I can only build

┌───────────┬──────────────┐
│ columnA   │ columnB      │
├───────────┼──────────────┤
│ itemA1    │ B            │
│ itemA2    │ C            │
│ itemA3    │ D            │

Using header (border=true) + body(borderLeft=true, borderRight=true)

@JakeWharton
Copy link
Owner

I believe the problem here is we do not allow the table itself to have a border. That can be fixed and then it collapsed with cell borders.

@JakeWharton JakeWharton added the enhancement New feature or request label Jan 14, 2020
@JakeWharton
Copy link
Owner

You can technically already do this by simply checking if you're on the last row and giving it a bottom border. But it's something we could simplify.

@onilton
Copy link
Author

onilton commented Jan 21, 2020

You can technically already do this by simply checking if you're on the last row and giving it a bottom border. But it's something we could simplify.

That's what I did as a workaround. Glad there is a better alternative now. I will try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants