Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics with extra non-scalar arguments #54

Closed
3 tasks done
jakirkham opened this issue Sep 29, 2017 · 3 comments
Closed
3 tasks done

Add metrics with extra non-scalar arguments #54

jakirkham opened this issue Sep 29, 2017 · 3 comments

Comments

@jakirkham
Copy link
Owner

jakirkham commented Sep 29, 2017

Some metrics take extra non-scalar arguments (e.g. vectors and arrays). There will need to be some adjustments both to the library and the tests to support this behavior. Have listed the metrics not yet implemented below.

@jakirkham
Copy link
Owner Author

With seuclidean and wminkowski, the functionality provided by these can be easily achieved by simply rescaling using the weights before passing it to euclidean or minkowski. So there is a fair question as to whether these are worth handling at all.

This was referenced Sep 29, 2017
@jakirkham
Copy link
Owner Author

Have some WIP PRs for these three functions (mahalanobis, seuclidean, wminkowski) linked by the cross references above. These all need tests and may need some optimization.

@jakirkham
Copy link
Owner Author

All are now added with tests. This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant