Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Filter out duplicate entries #14

Closed
mzur opened this issue May 5, 2021 · 10 comments
Closed

Feature Request: Filter out duplicate entries #14

mzur opened this issue May 5, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@mzur
Copy link

mzur commented May 5, 2021

My release list contains many duplicate entries like this:

image

Do you have an idea what could cause this? I'm willing to contribute if you can point me in the right direction.

@jakubito
Copy link
Owner

jakubito commented May 5, 2021

Hi Martin,

What you are seeing is not a bug - it is exactly the same data that is returned from Spotify API. Sometimes, an album is represented by multiple entries, each with a unique ID and different copyright wording. I'm not sure why labels do this, I assume there are some legal reasons behind it. If you search for London Grammar, you will see it's the same for the rest of their music too:

image

I haven't encountered this too often so I've never felt I need to come up with a workaround. My concern is how to pick the right entry from an array of duplicates - it's not as trivial as it seems. I can explain more if you are interested. I'd love to get some help on this project! 🙂

@mzur
Copy link
Author

mzur commented May 6, 2021

Maybe an opt-in to filter out entries with the same date, title and artist name would be a reasonable compromise. Even if you can't be sure that its the same title etc. the probability to filter out the wrong thing should be low (and its opt-in).

@jakubito jakubito added the enhancement New feature or request label May 10, 2021
@jakubito jakubito changed the title List contains duplicate entries Feature Request: Filter out duplicate entries May 25, 2021
@jakubito
Copy link
Owner

jakubito commented Aug 8, 2021

v2.0.1

@jakubito jakubito closed this as completed Aug 8, 2021
@mzur
Copy link
Author

mzur commented Aug 9, 2021

Thanks a lot for implementing this! Unfortunately I found that Spotify makes this even harder with different upper- and lowercase characters 😒

image

Maybe the filter should only use lowercase titles.

@jakubito
Copy link
Owner

@mzur This is now fixed in v2.0.2

@mzur
Copy link
Author

mzur commented Aug 10, 2021

Thanks, you're awesome 😊

@mzur
Copy link
Author

mzur commented Aug 20, 2021

Spotify also swaps round brackets with square brackets 🤦 I don't think that these duplicates can also be filtered out without handling every single edge case, so this information is just for the record.

image

@jakubito
Copy link
Owner

Ugh, this is very annoying. I don't think Spotify is to blame for this though. As far as I understand, it's a distributor's responsibility to submit properly named releases. I honestly have no idea why they submit the same release twice, only with different brackets in the title. It makes no sense 🙄

I will update the filter to treat all brackets the same, but I'm sure there are other edge cases. Please keep adding your findings here and I'll do my best to make it as robust as possible. Thank you!

@affinage
Copy link

affinage commented Oct 2, 2021

Found one more case: different apostrophe signs.

screenshot from spotifyreleaselist:
Screen Shot 2021-10-02 at 10 12 36 PM

screenshot from spotify
1633202163656

albums for reference:
I'm In Love (Redondo Remix)
I’m in Love (Redondo Remix)

@jakubito
Copy link
Owner

@mzur @affinage The filter has been updated in v2.0.3 to address edge cases you provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants