-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display minutes for time #388
base: master
Are you sure you want to change the base?
Conversation
This would be excellent to have merged if possible - just implemented my own (less good) solution here #398. Having this would really expand the ability to use this library in my opinion. @davidgoli is there any chance we could have this merged? |
AT() | ||
COLON() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main draw back with this approach is that lists of times are not supported though that may be intentional.
For example in the list case you would have to list all permutation for this to work
// Invalid
every day at 9:00 and 11:30 => RRULE:FREQ=DAILY;BYHOUR=9,11;BYMINUTE=0,30
// valid
every day at 9:00, 9:30, 11:00 and 11:30 => RRULE:FREQ=DAILY;BYHOUR=9,11;BYMINUTE=0,30
Personally, I think it's reasonable to limit this to one hour time combo to prevent confusion
Any updates? |
This diff is too large. Please revert all lint-style formatting changes (semicolons, quotes around property names, reformatting etc), rebase on master, and re-push. Thanks! |
pull request for issue #387
Hi everyone, I implemented the features I needed, as I described in the issue.