Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Autocomplete Overflow #6

Closed
jacquesuhlemann opened this issue Dec 21, 2023 · 3 comments · Fixed by #8
Closed

Feature request: Autocomplete Overflow #6

jacquesuhlemann opened this issue Dec 21, 2023 · 3 comments · Fixed by #8
Labels
enhancement New feature or request

Comments

@jacquesuhlemann
Copy link

Currently the autocomplete shows all existing tags, the list can become very long.

It would be perfect to use autocomplete in an overflow. Perhaps even in a popover so that other elements underneath are not moved too far.

Great work and many thanks

@JaleelB JaleelB added the enhancement New feature or request label Dec 22, 2023
@JaleelB
Copy link
Owner

JaleelB commented Dec 23, 2023

Hey @jacquesuhlemann. Thanks for the love, I appreciate it.

If I am understanding what you are saying, then a workaround to that issue is setting a max with on the container the autocomplete input is in.

The popover feature is a good feature idea. I am currently working on a few iterations. I'll push what I have in a bit

@eliza921
Copy link

I have tried with the Popover component and it was almost good! The only problem I noticed was when attempting to select the first tag it required two-clicks, which is not the intended behavior.

As a workaround, I tried wrapping the element with a component from shadcn.

@JaleelB
Copy link
Owner

JaleelB commented Dec 27, 2023

@jacquesuhlemann @eliza921 Thank you for your valuable feedback and suggestions regarding the Tag Input component. I've gone ahead and implemented the features you requested! Try it out and let me know what you think

Screen.Recording.2023-12-27.at.5.29.11.PM.mov

@JaleelB JaleelB linked a pull request Dec 27, 2023 that will close this issue
@JaleelB JaleelB self-assigned this Dec 27, 2023
@JaleelB JaleelB closed this as completed Dec 27, 2023
@JaleelB JaleelB removed their assignment Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants