Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Play 2.6 #611

Closed
kubukoz opened this issue Jun 26, 2017 · 2 comments
Closed

Support Play 2.6 #611

kubukoz opened this issue Jun 26, 2017 · 2 comments

Comments

@kubukoz
Copy link

kubukoz commented Jun 26, 2017

Play 2.6 is out, it'd be worth checking if it's compatible with the current release and documenting it (the homepage still says "Supports Play versions 2.1.x, 2.0.x and 1.x"), and, if needed, making it so.

@gmethvin gmethvin mentioned this issue Jan 11, 2018
@normenmueller
Copy link
Contributor

Yes, please open a branch for Play 2.6. For example

class MyController @Inject()(
  override implicit val env: MyEnvironment,
  cc: ControllerComponents
) extends AbstractController(cc)
  with securesocial.core.SecureSocial { ... }

causes

[error]   method parse in trait BaseControllerHelpers of type => play.api.mvc.PlayBodyParsers  and
[error]   lazy value parse in trait BodyParsers of type play.api.mvc.PlayBodyParsers

@gmethvin
Copy link
Contributor

gmethvin commented Mar 1, 2018

Working on this in #614. Feedback appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants