ANIM.CreateANIM() missing bones Taiko Wii U 2

[Y2K-x]

Yo, been trying to use Smash Forge to convert over some files from Taiko Wii U 2, with no luck.

My issue is that for some reason, Smash Forge isn't correctly exporting an animation file in .anim format, even though I believe I am doing everything correctly. In Maya, the animation doesn't load in at all, and I think I may have an inclination as to why.

This very much does not look normal to me. Albeit, this exact file was exported with an old version of forge (A commit I compiled from aprox. 3 months ago) but still shows a similar output on the very latest commit. Either this is a pretty long standing issue, or I'm just doing something wrong here. Anims display 100% fine in the viewport and everything, so I'm a bit lost here.

I think it's also worth mentioning that I had to build my own pac file in order for Forge to load in all the animations. In Taiko, the OMO animation files are all separate from each other for the model I'm messing around with, and since Forge doesn't support singular OMO files as far as I know from my testing, creating a pac using Sammi's old packmanager was my only real course of action. Hopefully this is just some dumb mistake on my end, but any help would be much obliged. Thanks.

[Y2K-x]

Oh, if needed, I can provide the files I've been using if further testing needs to be done. Just ask and you shall receive.

[Y2K-x]

I noticed that this was tagged as needing info. Please let me know what you need and I can provide it.

[Y2K-x]

I figured out the underlying issue. See, the omo animation Animation a never is actually populated with the proper bone names. So, when the export method tries to run through the bones listed in the VBN via line 241 (if (a.hasBone(b.Text)) { }), it fails, as all the bone names in the Animation object are null, while the names in the VBN bone tree are, well, not.

Hope these screenshots help:
Animation object bone array (in ANIM.cs, is instantiated as 'a')

vbn object bone array (in ANIM.vs, referenced as 'vbn')

Hope this helps you out in your efforts. I'll be looking to create my own solution, but I thought I would share my findings with you in case you come up with a better one. I'll post in here what I come up with.

[ScanMountGoat]

You can link a line or lines of code directly. The easiest is to select the lines, right click open new issue, and then copy paste the link.

Smash-Forge/Smash Forge/Filetypes/Animation/ANIM.cs

Line 241 in c4a820b

if (a.HasBone(b.Text))

[Y2K-x]

Ah, was not aware, thanks.

But anyways, I was successful in my attempts at "fixing" the issue. I won't make a PR simply because the way I did it was probably not the best way to go about it, but all I really did was pass Runtime.TargetVBN to the omo read method, and populated each bone with its respective name. This indeed does work, but I'm not sure nicely this plays with everything else.

Code:

[Dr-HyperCake]

This is likely the same issue as #365. If so, it would be fixed by updating the hash table with all of the relevant hashes, which requires access to the relevant VBN files.

A more complete solution would be to make Forge not require hashes to be in the hash table; instead, the mapping between names and hashes should be sourced from the active VBN file. I'm not sure exactly what code would need to be changed, though.