Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken insert in some instances #6

Closed
jamelt opened this issue Mar 25, 2019 · 2 comments
Closed

broken insert in some instances #6

jamelt opened this issue Mar 25, 2019 · 2 comments

Comments

@jamelt
Copy link
Owner

jamelt commented Mar 25, 2019

insertions not working on data in test for item 'h'
@jamelt
Copy link
Owner Author

jamelt commented Mar 25, 2019

turns out that our quadratic algorithm was wrong. the initial value was not actually worse but 0 so anytime there was a negative difference in the regions and their union, the algorithm would fail to assign an entry to a split.

@jamelt
Copy link
Owner Author

jamelt commented Mar 25, 2019

Fixed by commit 1286248

@jamelt jamelt closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamelt