support String type INFO fields with multiple values #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescasbon
pushed a commit
that referenced
this pull request
Jan 30, 2013
support String type INFO fields with multiple values
gotgenes
pushed a commit
to gotgenes/PyVCF
that referenced
this pull request
May 13, 2014
support String type INFO fields with multiple values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have String type INFO fields with multiple values, but PyVCF currently does not split these by the comma char into multiple values, it returns a single string. I see that there is a special exception for String type INFO fields in the code handling multiple values, so maybe you have a good reason for doing this (some legacy VCFs that have commas in INFO fields where they shouldn't?) But the VCF 4.1 spec does state that comma is reserved in INFO fields values for specifying multiple values, so the current behaviour is not standard (and I have to add special cases in my VCF-handling code to work around).