Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width of cards is based on window height #68

Closed
wejrox opened this issue Jul 5, 2021 · 2 comments · Fixed by #83
Closed

Width of cards is based on window height #68

wejrox opened this issue Jul 5, 2021 · 2 comments · Fixed by #83
Assignees
@ChrisNeedham24
Labels
bug Something isn't working good first issue Good for newcomers UI

Comments

@wejrox
Copy link

wejrox commented Jul 5, 2021

Cards use the window height to set their width. Open the profile for a user and open dev tools on the bottom. That doesn't seem right.
@wejrox
Copy link
Author

wejrox commented Jul 5, 2021

Issue seems to be in PlayerCard.css .ui.card.player-card using vh for some reason.

@ChrisNeedham24 ChrisNeedham24 added bug Something isn't working UI good first issue Good for newcomers labels Jul 5, 2021
@ChrisNeedham24 ChrisNeedham24 self-assigned this Jul 10, 2021
@ChrisNeedham24
Copy link
Collaborator

Turns out this also occurs in Ladder.css for the player cards, and for the happy hour popover.

@ChrisNeedham24 ChrisNeedham24 linked a pull request Jul 10, 2021 that will close this issue
Made various CSS fixes. #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisNeedham24 ChrisNeedham24

Labels
bug Something isn't working good first issue Good for newcomers UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made various CSS fixes. jamesgiu/quick-hit
2 participants
@ChrisNeedham24 @wejrox