Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong FPS for QuictTime (mov) files #54

Closed
tomaszkane opened this issue Sep 30, 2015 · 2 comments
Closed

Wrong FPS for QuictTime (mov) files #54

tomaszkane opened this issue Sep 30, 2015 · 2 comments

Comments

@tomaszkane
Copy link

Hi,
I download Tears of Steel in 720p .mov from https://mango.blender.org/download/ and $fileInfo['video']['frame_rate'] says it has 1000 fps.

I believe it's wrong.

@ar-turek
Copy link

I think I can help pinpoint the issue a bit better.

In line 167 the frame rate for the video is being set if it has not been set before. But for the Tears of Steel .mov file the frame rate is already set to 1000 after a call to QuicktimeParseAtom in line 140 while parsing the 'moov' atom.

Also tested it on other files and there is no such issue.

JamesHeinrich added a commit that referenced this issue Oct 3, 2015
#54
Ignore time_scale values of >=1000 to attempt to set correct video frame
rate while ignoring global and audio time_scale values
@JamesHeinrich
Copy link
Owner

QuickTime is sometimes annoying to work with due to the possibility of variable framerates, and framerate values (like most other things QuickTime) are store in multiple places.

I have made a change that should fix this particular problem, perhaps other similar problems, but there's also a small chance it may have broken some previously-working files. Please let me know if that is the case.
bdf0739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants