Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lv-exe option causes an unhandled exception in 2.0.0b1 #54

Closed
JamesMc86 opened this issue Sep 13, 2018 · 2 comments
Closed

lv-exe option causes an unhandled exception in 2.0.0b1 #54

JamesMc86 opened this issue Sep 13, 2018 · 2 comments
Labels
bug

Comments

@JamesMc86
Copy link
Collaborator

In the line below we don't add the other version parameters when using an lv-exe option.

Later the port registration tries to use these for an ID. We need to enter placeholders at least here

https://github.com/JamesMc86/LabVIEW-CLI/blob/0a0c45c265326829c9423f1da99a9391f9027438/C%20Sharp%20Source/LabVIEW%20CLI/Program.cs#L218
@JamesMc86 JamesMc86 added the bug label Sep 21, 2018
@JamesMc86
Copy link
Collaborator Author

Even with the fix there we have a problem because of the LabVIEW end using the version number to find it's port. I think we will have to deprecate this option.

JamesMc86 added a commit that referenced this issue Sep 22, 2018
@JamesMc86
Deprecated lv-exe option as per #54
488e10b
@JamesMc86
Copy link
Collaborator Author

Deprecated for next 2.0.0 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesMc86