Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have make_dataset not rely on torch #54

Closed
apmcleod opened this issue Oct 9, 2019 · 2 comments
Closed

Have make_dataset not rely on torch #54

apmcleod opened this issue Oct 9, 2019 · 2 comments
Labels
design This pertains to design decisions

Comments

@apmcleod
Copy link
Collaborator

apmcleod commented Oct 9, 2019

I guess it's ok if the package requires torch, but users that have issues installing pytorch for whatever reason would ideally still be able to run make_dataset.py. I don't think it is actually required.
@apmcleod apmcleod added the design This pertains to design decisions label Oct 9, 2019
@apmcleod
Copy link
Collaborator Author

apmcleod commented Oct 9, 2019

I think this would just involve moving df_to_command_str to another file.

This was referenced Oct 9, 2019
Merged
Merged
@apmcleod
Copy link
Collaborator Author

Fixed by #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design This pertains to design decisions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apmcleod