-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
areas appears selected in UI after rebind even though its selected state !== true #378
Comments
The docs indicate that Prior to commit 3de37f3 (line 723) this was true. However, in this commit, the behavior changed to not persist previously selected state and instead, completely rebuild Area Data items. This change does appear intentional as the test case related to Given the code changes in The net result of this commit is that Trying to find a reliable and deterministic approach to maintaining selected state while still respecting the options passed gets complicated and could lead to different behavior in certain situations. For example:
Based on all of this, shifting this issue from treating it as selected state should still be selected to the area should no longer be drawn since its no longer selected after a One additional note regarding behavior rebind - As written, it expects that the AREAS have not been modified in any way expect for the |
Describe the bug
Per the docs,
rebind
should apply the options passed and re-render but it should not modify state. Currently, after callingrebind
, a selected area remains visibly selected but the area itself no longer has a state of selected (e.g.get
API does not include the key).To Reproduce
Steps to reproduce the behavior:
Selected Keys
reflects the members nameRebind
Update Keys
- This is required due to issue onConfigured not called after rebind #377Expected behavior
The member should maintain its selected state and the
Selected Keys
should still include the members name.Screenshots
N/A
Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: