Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests not waiting for onConfigured before continuing #381

Closed
techfg opened this issue Feb 20, 2021 · 0 comments · Fixed by #383
Closed

tests not waiting for onConfigured before continuing #381

techfg opened this issue Feb 20, 2021 · 0 comments · Fixed by #383
Labels
Milestone

Comments

@techfg
Copy link
Collaborator

techfg commented Feb 20, 2021

Describe the bug
basic and resize tests do not wait for onConfigured to fire when initializing/rebinding resulting in some tests not executing. This issue was introduced in commit 223ef68 when when.js was eliminated not do to a change in functionality but rather a slight perf hit which slowed things down just enough for init not to mark IM as complete === true.

To Reproduce
Steps to reproduce the behavior:

  1. Run tests
  2. resize tests assert count === 20; basic tests assert count === 2

Expected behavior

  1. Resize tests assert count is correct but should be waiting for onConfigured before continuing
  2. Basic tests assert count should be 36 (37 after fix)

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@techfg techfg added the bug label Feb 20, 2021
@techfg techfg added this to the 1.5.4 milestone Feb 20, 2021
techfg added a commit that referenced this issue Feb 21, 2021
Resolves #83 
Resolves #377
Resolves #378
Resolves #380
Resolves #381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant