Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the design of TopoModif #50

Closed
Diego635 opened this issue Jul 22, 2019 · 4 comments
Closed

Modify the design of TopoModif #50

Diego635 opened this issue Jul 22, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request modify_tb Issues related to "Modify Topo/Bathymetry" Solved This issue has been solved and will be closed
Milestone

Comments

@Diego635
Copy link
Collaborator

We need to implement rescaling in the tool.
This could be 3 options:

  1. Modification with formula
    Here we should ask for:
  • Bounding values (bounding min / bounding max)
  • Formula
  1. Heightening / flattening
    Here we should ask for:
  • Final maximum (the user chooses the highest value of the resulting topography)
    The minimum value should be taken automatically from the raster. And we shouldn't give the possibility to choose a minimum here, it's to confusing.
  1. Rescaling
    Here we should be asking for:
  • Bounding values (bounding min / bounding max)
    --> If there is an empty field here, the original min and max values from the raster should be taken.
  • Final max and final min (the desired values for the resulting topography)
@Diego635 Diego635 added enhancement New feature or request modify_tb Issues related to "Modify Topo/Bathymetry" labels Jul 22, 2019
@Diego635 Diego635 added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jul 22, 2019
@Diego635 Diego635 added this to the Version 0.2 milestone Jul 23, 2019
@Diego635 Diego635 added the Solved This issue has been solved and will be closed label Oct 30, 2019
@Diego635
Copy link
Collaborator Author

Diego635 commented Nov 14, 2019

This is partially solved. The points 2. and 3. need to be revised (perhaps no need to implement them?)

@Diego635
Copy link
Collaborator Author

When the option to take the min/max values or the formula from the attributes is selected, the comboboxes should replace the spinboxes. This will make the interface look more clear.

@Diego635 Diego635 removed the Solved This issue has been solved and will be closed label Nov 22, 2019
@Diego635
Copy link
Collaborator Author

Diego635 commented Feb 6, 2020

The tool has become too complicated. It works but the interface could be more user-friendly. A series of pop-up windows (Installation wizard with next buttons), similar to a software installation, might work better.
see #129
Possible tree:
Input > Formula or MinMax modification > depending in the modification type chosen, corresponding settings > Output and log.

First specify data types that the user has and then merge masks

@jaminzoda
Copy link
Owner

To keep it consistent with the overall dialogs design and to implement a single base dialog that is used by all the algorithms the TopoModify dialog is simplified instead of providing parameters on separate pages of a wizard. Fixed in 0300073

@jaminzoda jaminzoda added the Solved This issue has been solved and will be closed label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modify_tb Issues related to "Modify Topo/Bathymetry" Solved This issue has been solved and will be closed
Projects
None yet
Development

No branches or pull requests

2 participants